Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript 'ContractOptions' interface #2939

Merged
merged 5 commits into from
Jul 16, 2019

Conversation

geigerzaehler
Copy link

  • Make all fields optional
  • Add transactionConfirmationBlocks field
  • Document all fields

Note that the list of options is still not exhaustive but I was unable to confidently determine the types of the other options.

* Make all fields optional
* Add `transactionConfirmationBlocks` field
* Document all fields

Note that the list is still not exhaustive but I was unable to
confidently determine the types of the other options.
@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage remained the same at 95.636% when pulling 22c5571 on geigerzaehler:contract-options-typescript into f2ac320 on ethereum:2.x.

@nivida nivida added 2.x 2.0 related issues In Progress Currently being worked on Types Incorrect or missing types labels Jul 12, 2019
@nivida nivida removed the In Progress Currently being worked on label Jul 16, 2019
@nivida nivida merged commit 02a251d into web3:2.x Jul 16, 2019
@geigerzaehler geigerzaehler deleted the contract-options-typescript branch July 16, 2019 14:55
@nivida nivida mentioned this pull request Aug 5, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 2.0 related issues Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants